feat: add netherlands-cbs 🇳🇱 and sweden-scb 🇸🇪 data sources#57
Merged
firstdata-dev merged 1 commit intomainfrom Mar 16, 2026
Merged
feat: add netherlands-cbs 🇳🇱 and sweden-scb 🇸🇪 data sources#57firstdata-dev merged 1 commit intomainfrom
firstdata-dev merged 1 commit intomainfrom
Conversation
mingcha-dev
approved these changes
Mar 16, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
✅ CBS api_url 已修正为 OData v4 (odata4.cbs.nl)，与建议一致。LGTM 👍
mingcha-dev
approved these changes
Mar 16, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #57
- ✅ CBS api_url 已修正为 OData v4:
odata4.cbs.nl/CBS/Datasets - ✅ SCB api_url 路径调整为
/doris/en（去掉 /ssd 后缀） ⚠️ 当前 CBS/SCB 均因 Mac mini 代理问题无法验证（解析到 198.18.x.x），URL 格式正确- ✅ 无重复 ID
通过 ✅ 建议合并
firstdata-dev
commented
Mar 16, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. CBS api_url 已修正为 OData v4。建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two European national statistics offices.
✅ Schema validation passed (256 unique IDs)
✅ CBS api_url updated to OData v4 endpoint